Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct variable names - these are not dates, but week-of-the-year numbers #8291

Merged
merged 1 commit into from
Jan 8, 2025
Merged

correct variable names - these are not dates, but week-of-the-year numbers #8291

merged 1 commit into from
Jan 8, 2025

Conversation

stopfstedt
Copy link
Member

follow-up to #8288

@stopfstedt stopfstedt marked this pull request as ready for review December 30, 2024 17:52
jrjohnson
jrjohnson approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change!

@jrjohnson jrjohnson added the run ui tests Run the expensive UI tests label Jan 6, 2025
@jrjohnson jrjohnson enabled auto-merge January 6, 2025 19:39
@jrjohnson jrjohnson merged commit fc3de9b into ilios:master Jan 8, 2025
42 checks passed
@stopfstedt stopfstedt deleted the better_var_names branch January 8, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelchadwick michaelchadwick michaelchadwick approved these changes

@jrjohnson jrjohnson jrjohnson approved these changes

Assignees
No one assigned
Labels
run ui tests Run the expensive UI tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stopfstedt @jrjohnson @michaelchadwick